Use any available encoding converter - Githubissues

t1gor / Robots.txt-Parser-Class

Php class for robots.txt parse

MIT License

83 stars 31 forks source link

Use any available encoding converter #74

Closed JanPetterMG closed 3 years ago

JanPetterMG commented 8 years ago

Currently we're using both mbstring and iconv without even requiring them in the composer.json.

[x] Require mbstring (there's no way around).
[ ] Drop iconv dependency (shall not be required, is optional)

The spec is expecting UTF-8, everything else is just an bonus if we can read and parse it properly.

How about requiring mbstring only , and then use whatever is available, if anything is available at all?

[ ] 1st priority - Use UConverter if available (optional)
[ ] 2nd priority - Use iconv only if it's available (shall not be required in any way).
[ ] 3rd priority - Use utf8_encode if available AND the encoding is ISO-8859-1 (optional)
[x] 4th priority - Use mbstring (there's no way around).