t1m0thyj / WinDynamicDesktop

Port of macOS Mojave Dynamic Desktop feature to Windows
https://windd.info
Mozilla Public License 2.0
4.42k stars 295 forks source link

The app cannot import themes if it uses certain language #580

Closed ghost closed 7 months ago

ghost commented 8 months ago

Hello. When I use the app in Javanese translation, I can't import the theme at all. I can only download themes available in the library on the left. Every time I try to import a theme (either by clicking the 'import from file' button or directly double-clicking the .ddw file), the import process gets stuck, and the progress bar doesn't move at all (like the image below). This problem occurs in all apps, both from GitHub and Windows Store.

image

Surprisingly, when I tried using another language (eg: French), the theme import process occurred without a hitch. image

Please investigate this bug. Thank You.

t1m0thyj commented 7 months ago

This is due to some translations like Javanese having invalid format strings with placeholders like {0} or {1} missing.

I've added a script to detect invalid translation strings, and they should be fixed now. You can download a preview build here: https://github.com/t1m0thyj/WinDynamicDesktop/actions/runs/8577479010

ghost commented 7 months ago

It's works! Thankyou.