search

t27duck / active_reporting

OLAP-like DSL for ActiveRecord-based reporting
MIT License
136 stars 19 forks source link

Label configuration hash instead of just a symbol #16

Closed andresgutgon closed 6 years ago

andresgutgon commented 6 years ago

Explained with more details in this issue

t27duck commented 6 years ago

Looks good so far. Thanks for your contribution... There's a couple issues that I'd like to see changed/resolved...

So, this is specifically to add the ability to change the key for a hierarchical dimension? I'm not sure I'm 100% on bored with allowing the use to completely change what the key is, especially if it only applies to hierarchical dimensions. Would a possible compromise be (using the example in your issue) instead of having the key be gender, could we always combine the dimension name + the hierarchical level (making it employee_gender)? If not, I'd rather have allow the user to override the key for ANY dimension to be whatever they want.

Also, the README should probably be updated to reflect whatever change/option you are adding, if possible.

andresgutgon commented 6 years ago

Hi @t27duck thanks for your quick response! I tried to fix your concerns. Let me know if it's ok now