Fix ransack_fallback - Githubissues

t27duck / active_reporting

OLAP-like DSL for ActiveRecord-based reporting

MIT License

136 stars 19 forks source link

Fix ransack_fallback #8

Closed germanotm closed 6 years ago

germanotm commented 6 years ago

Hi Tony.

I just used your gem to add some reports to my rails app. Great work, i loved it.

I found some bugs when using ransack_fallback on FactModel. I fix these bugs and its now working properly with ransack. I also writed two test covering the ransack_fallback errors.

Thanks.

t27duck commented 6 years ago

Thank you very much for the fix! I'm really sorry I haven't been around to get this in sooner. I appear to have my Github notifications off for this repo 😢

The travis issues are resolved in master now. I'll merge this in and make any corrections if the tests still have issues.

Sorry again for the delay!

t27duck commented 6 years ago

Version 0.3.0 is out with this change in it.