t3-innovation-network / desm

Data Ecosystem Schema Mapper
Apache License 2.0
9 stars 4 forks source link

Downloaded DESM File Name Issue: Does Not Use the Full Specification Name and Concatenates the Mapper Name with and Incomplete Specification Name #543

Open jeannekitchens opened 3 weeks ago

jeannekitchens commented 3 weeks ago

This needs to be a priority 1 issue that goes along with the in progress export-related issues. In this case, it was a pain to have to go back and re-download and rename due to the downloaded file not having the full name. Seems like a quick fix.

When a mapping is downloaded, the name of the file is not correct. It concatenates the name of the mapper and only part of the schema name. This file name should be Open Badges 2.0 (1EdTech) - Issuer. It should not be what is seen in the download screenshot. This issue cause me to have to keep track and rename each downloaded file to remove the mappers name and identify the full name of the specification. image

As seen via, copy/paste below and the screenshot below the title is incorrect.
dcterms:title: "Nate Otto - Open Badges (1EdTech) - Micro-credential Specification", image

I believe Phil has identied the name as an issue in respect to removing the name of the mapper. This issue shows that the full name of the specification is not used with the download and needs to be used everywhere in the UI and with the downloaded data.

excelsior commented 3 weeks ago

@jeannekitchens Please clarify the following:

  1. Currently, the file name looks like Nate Otto - Open Badges 2.0 (1EdTech) - Issuer. It be Open Badges 2.0 (1EdTech) - Issuer. Is that correct.
  2. Should the mapping's dcterms:title in the file itself be the same as the file name (save for the extension, of course).
  3. Should the mapping's version (if present) be included into either?
philbarker commented 3 weeks ago

@excelsior let me know if this leads to any file name conflicts

  1. yes to removing the mappers name from the file name
  2. I think it may need to be more just the title. (I'm not 100% sure what is in the title)
  3. do you mean mapping version or schema version? Probably yes to both. Schema versions are important and it would help avoid name clashes if the date of mapping were in the file name.

We probably don't need the organization in the file name.

Can we not have spaces or brackets in file names please?

philbarker commented 3 weeks ago

Ah, sorry, @excelsior I think I misunderstood Q2. If you were asking what to put into the dc:title (rather than the other way how to use what was in it), then «project name»+«abstract class»+«schema name»+«schema version» (which is similar to now but without any person's name and in different order. That order will help group mappings when displayed alphabetically.

Add the last mod date to that at the end and I think you have the file name.

jeannekitchens commented 3 weeks ago

@excelsior Phil's concatenation for the title is what we should see via the UI and the downloaded file.