tadjik1 / github-viewer

Simple github viewer that allows you to search users by programming languages
3 stars 0 forks source link

Why not yarn? #1

Open Bloomca opened 7 years ago

Bloomca commented 7 years ago

Basically same thing as npm-shrinkwrap, but resolves dependencies a bit faster, and seems pretty stable.

tadjik1 commented 7 years ago

@Bloomca thanks for comment! I agree, yarn seems like a good replacement for npm. I've used npm here because it's an "in box" solution and I've decided not to spend extra time for yarn integration. But it's a good point for improvement :)

Bloomca commented 7 years ago

Well, it is actually very easy to integrate, I can even make a PR for it =).

You just install yarn through npm or brew (I like brew more because then you don't have to link it in your .zshrc), and then npm install package -> yarn add package, and it updates yarn.lock automatically.

tadjik1 commented 7 years ago

@Bloomca if you want to make a PR please make sure to add required configuration to all currently used places:

Bloomca commented 7 years ago

Travis claims to do automatically if yarn.lock is presented.

For heroku I am not that sure, what is the easiest way to deploy it there and also how do you build docker container locally?

tadjik1 commented 7 years ago

for building and running docker container locally you can use this instructure.