search

tagyoureit / nodejs-Pentair

An application to read/write to Pentair pool controllers.
14 stars 6 forks source link

Added solar temp support #1

Closed rflemming closed 8 years ago

rflemming commented 8 years ago

I was just tinkering with this and noticed you hadn't identified the solar temp sensor field, so I added it.

tagyoureit commented 8 years ago

Thanks, that's great! There is a ton more to do. Let me know (or branch off) if you see anything else. I'm going to post what I learned about the configuration for the controllers in a bit... I'll need a lot of help with that!

rflemming commented 8 years ago

I'm not entirely sure how much I'll be able to help, but I've been following your changes and saw this as an easy addition. I've been tinkering with code from a couple folks and while yours isn't the most feature complete yet (ie write operations, wrapping it in a REST interface or similar, etc) it's the most versatile code out there, in that it isn't full of things hard coded to one person's equipment. Amen to that. I'm happy to test on my equipment and will submit pull requests if I think I have anything to offer. Neither node.js, nor wire protocols are in my wheel house, but we'll see what I come up with :) Take Care and thanks.

Robert

On Sat, Jun 4, 2016 at 5:30 PM tagyoureit notifications@github.com wrote:

Thanks, that's great! There is a ton more to do. Let me know (or branch off) if you see anything else. I'm going to post what I learned about the configuration for the controllers in a bit... I'll need a lot of help with that!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tagyoureit/nodejs-Pentair/pull/1#issuecomment-223786024, or mute the thread https://github.com/notifications/unsubscribe/AHeuuJwBUlqQ0TvajqxWln5cVCJ6UIIcks5qIhijgaJpZM4IuCg9 .