tahoma2d / tahoma2d

2D and Stop Motion Animation Software
https://tahoma2d.org
Other
359 stars 59 forks source link

Some windows shrink on open in active room #192

Closed artisteacher closed 4 years ago

artisteacher commented 4 years ago

Describe the bug On macOS, when Tahoma opens, the Timeline, Style Editor, and Stop Motion Controls windows shrink if they are in the active room upon opening. It's possible that other windows could have the same issue, but these are the only ones that are a problem in the default setup. Rooms that were inactive on opening keep their sizes as expected.

To Reproduce

  1. Open Tahoma after install - the 2D room's Timeline is shorter than the other rooms & the Style Editor is narrower than expected
  2. Adjust window sizes to fit the screen better - or switch to the Stopmotion room
  3. Close Tahoma
  4. Reopen Tahoma - changes to the 2D room are reset if it is active on open; if the stopmotion room is active, the Stop motion controls & Timeline are barely visible.

Expected behavior The widths/heights of windows should not change on opening just because they are in the active room.

Screenshots

2D room after adjustments:

Screen Shot 2020-09-21 at 6 11 49 PM

2D room on install & after reopening if active:

Screen Shot 2020-09-21 at 6 09 55 PM

Stopmotion room if not active on open:

Screen Shot 2020-09-21 at 6 10 26 PM

Stopmotion room if active on open:

Screen Shot 2020-09-21 at 6 13 53 PM

Device Information:

artisteacher commented 4 years ago

commenting out lines 524-527 and 552-557 in docklayout.cpp

Does fix the Timeline height issue.

ghost commented 4 years ago

I made a PR removing the timeline fixed height stuff. I'm not sure what's causing the others, but I'll take a look.

artisteacher commented 4 years ago

Thanks for looking!

artisteacher commented 4 years ago

Timeline's working much better now!

Are the Style Editor & Stop Motion Controls fixed width upon open? They only need to be fixed when resizing the program window...

ghost commented 4 years ago

On Windows, they need to be fixed when starting. Perhaps I can make the resize on start Windows only.