Refactor price gathering to allow multiple data sources

tahowallet / extension

Taho, the community owned and operated Web3 wallet.

https://taho.xyz

GNU General Public License v3.0

3.11k stars 394 forks source link

Open mhluongo opened 3 years ago

mhluongo commented 3 years ago

Let's make it easy to add new price sources — there's already interest in ChainLink feeds as well as particular exchange APIs.

[x] Package up "check price of asset A, B, & C against assets X, Y, & Z" into a single interface
[ ] Implement the interface for CoinGecko
[ ] Modify IndexingService to check using multiple configured sources

Examples to motivate can be found by grepping the codebase for "coingecko" :sweat_smile:

Shadowfiend commented 3 years ago

A specific case to exemplify the category of change we're looking for, where I ask us to try to make sure that source info is carried as early as possible so that there's minimal opportunity to lose it: https://github.com/tallycash/tally-extension/pull/213#discussion_r707425256

0xDaedalus commented 1 year ago

https://docs.1inch.io/docs/spot-price-aggregator/introduction is another source (and much more decentralized than coingecko)