tajo / ladle

🥄 Develop, test and document your React story components faster.
https://www.ladle.dev
MIT License
2.63k stars 93 forks source link

Add type="button" to all buttons #402

Closed wojtekmaj closed 1 year ago

wojtekmaj commented 1 year ago

Reduces the noise coming from Microsoft Edge "Issues" tab in DevTools:

image
changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 3ea6fa87ef9d7fe1c71980cf58e179b91cd84110

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages | Name | Type | | ----------------- | ----- | | @ladle/react | Patch | | example | Patch | | test-addons | Patch | | test-config | Patch | | test-config-ts | Patch | | test-css | Patch | | test-decorators | Patch | | test-flow | Patch | | playwright | Patch | | test-programmatic | Patch | | test-provider | Patch | | test-swc | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
ladle ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 22, 2023 at 5:49PM (UTC)
tajo commented 1 year ago

That's a strange tip. It should not matter unless you put button into form?

wojtekmaj commented 1 year ago

I guess it's mostly "better be explicit at all times than be surprised later when something changes around the already-implemented button". Tip links to this article:

https://webhint.io/docs/user-guide/hints/hint-button-type/