search

tajo / ladle

🥄 Develop, test and document your React story components faster.
https://www.ladle.dev
MIT License
2.63k stars 93 forks source link

Split NoStories and StoryNotFound components, improve wording, add Back to home link, fix typo in GitHub name #413

Closed wojtekmaj closed 1 year ago

wojtekmaj commented 1 year ago

NoStories component served two purposes, and these purposes had little in common. Furthermore, it was not fully type safe as all props were optional. Splitting these components make them easier to work with.

I added Back to home link so that if you are in full screen mode without navigation you still have an easy escape hatch.

I fixed GitHub name which had a typo in it.

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 8721a58a970ba05c951fcd404568d9afd63d55ce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages | Name | Type | | ----------------- | ----- | | @ladle/react | Minor | | example | Patch | | test-addons | Patch | | test-config | Patch | | test-config-ts | Patch | | test-css | Patch | | test-decorators | Patch | | test-flow | Patch | | test-playwright | Patch | | test-programmatic | Patch | | test-provider | Patch | | test-swc | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ladle ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 13, 2023 5:16am
tajo commented 1 year ago

I added Back to home link so that if you are in full screen mode without navigation you still have an easy escape hatch. I fixed GitHub name which had a typo in it.

I don't see those changes in this PR?

wojtekmaj commented 1 year ago

@tajo Here they are:

https://github.com/tajo/ladle/pull/413/files#diff-bf4956845f2d059f862076ae2da586e00e42facffe51cfed839d59b858405766R11

and

https://github.com/tajo/ladle/pull/413/files#diff-058add2e7cfee0c1f9769cf951d24ed9c3d72db07ef8aac9b0ef536ad141d170L37 -> https://github.com/tajo/ladle/pull/413/files#diff-058add2e7cfee0c1f9769cf951d24ed9c3d72db07ef8aac9b0ef536ad141d170R18

tajo commented 1 year ago

I added Back to home link so that if you are in full screen mode without navigation you still have an easy escape hatch.

Ah got it. I thought this applies to full screen mode in general. https://github.com/tajo/ladle/issues/404

Anyway thanks.