search

takari / polyglot-maven

Support alternative markup for Apache Maven POM files
Eclipse Public License 1.0
893 stars 101 forks source link

polyglot-kotlin docs still mention KT-27956 #250

Open seanf opened 2 years ago

seanf commented 2 years ago

The docs for polyglot-kotlin still mention the Kotlin issue KT-27956, but this issue and the follow-up KT-33892 are marked as fixed since Kotlin 1.3.60.

Is the performance impact still present?

seanf commented 2 years ago

@lion7 @thorntonrp Am I right in thinking that your changes in https://github.com/takari/polyglot-maven/pull/184 probably took care of the performance problem mentioned in the readme for polyglot-kotlin? That PR seems to have eliminated all references to ScriptEngine.

https://github.com/takari/polyglot-maven/blob/5a92df156dc221792cc06443cab1f4b4f93f1b12/polyglot-kotlin/README.md?plain=1#L96-L112

lion7 commented 2 years ago

I think you are correct, the performance problem should be gone now that the ScriptEngine is no longer used. Maybe you could create a PR to remove this known issue? The one thing I'm not sure of, is how to measure that it is indeed gone. I'm hoping 1 of the maintainers has a more solid opinion on this, @mosabua perhaps?