search

takari / polyglot-maven

Support alternative markup for Apache Maven POM files
Eclipse Public License 1.0
893 stars 101 forks source link

Replace signing #275

Closed cstamas closed 1 year ago

cstamas commented 1 year ago

We are forced to use takari-lifecycle 2.0.8 to support Java 8 building this project, but alas, signing using that version is busted.

Hence, we need to skip it, and provide alternate way using vanilla plugin, as Central requires signatures.

IMHO, this is okay compromise, as signing still happens in takari-release profile only.

Fixes #274.

cstamas commented 1 year ago

@lefou @headius @mosabua just FYI

cstamas commented 1 year ago

Other (not unrelated) problem is that sources for https://github.com/takari/jpgp are lost, as in, repo contains only 2 versions, but repo has many more (newer): https://repo.maven.apache.org/maven2/io/takari/jpgp/

lefou commented 1 year ago

Huh, what happened to the repo or the newer commits? were they never pushed to Github? Or is this project abandoned in general? Maybe, there are other forks of it with the missing commits? FWIW, there are published sources for the newer versions on Maven Central. One option could be to commit them, version by version, to the git repository, and continue maintenance from there.

Btw, thank you @cstamas for your work keeping this project vital. ❤️

cstamas commented 1 year ago

did 0.5.0 with this change, we need to sort this out https://github.com/takari/polyglot-maven/releases/tag/polyglot-0.5.0

cstamas commented 1 year ago

Yes, I guess this was the result of release process not pushing automatically, but should be done manually... easy to forget, if someone works on one computer and pushes fixes out.

Problem is that 1.0.6 used by current takari-lifecycle is not even binary compatible with 1.0.9 that works for me on my Fedora....