search

takari / takari-plugin-testing-project

Maven Plugin Testing Framework
Eclipse Public License 1.0
27 stars 19 forks source link

Add support for JUnit 5 #38

Closed marschall closed 2 years ago

marschall commented 2 years ago

This pr adds support for JUnit 5 along side JUnit 4.

The chosen approach focuses on maximising code reuse while minimziging code changes.

The assertions in AbstractTestResources require JUnit 4 to always be present.

Different approaches are certainly possible, one would for example be to make dedicates module for JUnit 4 and JUnit 5.

cyrille-leclerc commented 2 years ago

Thank you very much for this improvement! We should be able to leverage very soon the takari-plugin-testing-project in the opentelemetry-maven-extension (here). It will greatly help us control our quality.