search

takluyver / jupyter_kernel_mgmt

Experimental new kernel management framework for Jupyter
https://jupyter-kernel-mgmt.readthedocs.io/en/latest/
Other
15 stars 8 forks source link

Is there any instruction to use it with (a fork of) notebook ? #3

Open Carreau opened 5 years ago

Carreau commented 5 years ago

Or any other clients.

I'm currently trying to write a SlurmKernelManager, and that seem more adequate as it is async all-the -way.

I can also try to "just figure it out", or maybe it's not time yet ?

takluyver commented 5 years ago

The changes to use this were landed in jupyter_kernel_test in master already, and I started a pull request for nbconvert. I don't think there's any fork of the notebook server using it yet; that will probably be a bigger job.

takluyver commented 5 years ago

Actually, this reminds me that there's an API question I've been wanting to get a second opinion on:

When a client makes a request to a kernel, the reply can have status: 'ok' or status: 'error' (or 'abort'). At present, if the reply status is 'error', the client raises an ErrorInKernel exception. However, both in jupyter_kernel_test and in the PR for nbconvert, I've ended up catching this exception and handling the message object as if it had been returned.

So I'm wondering if the client object should just return the reply message, whatever its status is, and let the application code deal with checking the status.

takluyver commented 5 years ago

I now have a WIP branch where I'm making the notebook server use this.