search

talaia-labs / python-teos

The Eye of Satoshi - Lightning Watchtower
https://talaia.watch
MIT License
100 stars 15 forks source link

Clean up apt caches in docker image #266

Closed 3nprob closed 3 years ago

3nprob commented 3 years ago

Removes unnecessary apt caches from final docker image

sr-gi commented 3 years ago

LGTM.

As a matter of curiosity, have you checked what is the size reduction by removing the tmp files and not installing the recommended packages?

3nprob commented 3 years ago

Honestly no; just noticed it as low-hanging fruit as I set it up :)

sr-gi commented 3 years ago

Hey @3nprob, saw you requested a review on this again. This has already been approved, will merged it to master asap.

sr-gi commented 3 years ago

Just an update on this. I haven't merged yet since I'm trying to port the same changes to the arm32 and arm64 images, but testing is proving to be quite time consuming.

Just a nit, would you mind rebasing and formatting lines 5-8 with a tab (4 spaces) instead of 2 spaces? I'll do it myself otherwise once I add the changes to the other two Dockerfiles.

3nprob commented 3 years ago

Thanks for the update :) Rebased and amended

sr-gi commented 3 years ago

I've applied the changes to the arm based images.

However, there's an issue with grpcio for arm32v7 that makes teos to crash when built via docker using grpcio==1..37.0 (see #287). I'm going to leave this open for a couple more days just in case I can get some feedback about it and try to squeeze the fix. Otherwise I'll merge and deal with it before the next release.

sr-gi commented 3 years ago

@3nprob I'm going to finally merge this given the issue has not been patched yet by the gRPC guys. I'll deal with that specific issue before the next release.

Would you mind rebasing for the last time?

3nprob commented 3 years ago

@sr-gi rebased