Closed jeheydorn closed 3 years ago
rntz
commented
3 years ago Hi! Are you using dragon, or wav2letter? Also, are you on the talon slack? It might be easier to do some interactive debugging on there if one of the other repository maintainers happens to be around (I'm afraid I'm about to go to sleep, unfortunately).
jeheydorn
commented
3 years ago I'm using dragon 15 professional individual.
I do believe I have a free slack account, but at the moment I'm heading out for the day.
For now I have reverted to the older version of talon.
rntz
commented
3 years ago Hm, I don't have Dragon so I may not be able to help. I've not seen this behavior on wav2letter and I've used dictation mode a fair bit so I think this is probably a Dragon-Talon specific issue. @knausj85 or @dwiel, can either of you reproduce this with Dragon?
If you do get the time to visit the slack, you can try asking in #help or #community. It might also help to get the Talon log output and/or your Talon command history from when the issue occurs.
knausj85
commented
3 years ago I think this is a result of two things: (1) Talon's been modified to return the word, rather than the symbol, via the dictate.parse_words action. https://github.com/knausj85/knausj_talon/blob/master/code/vocabulary.py#L88 (2) Can't override dragon commands - https://github.com/talonvoice/beta/issues/34
Consistent with the workaround in the above issue, the reason it works in command mode is that it's part of a capture/list https://github.com/knausj85/knausj_talon/blob/master/code/keys.py#L121.
I think we'd need something like rntz' change for dictation mode, if we want this functionality-it would need to map ',' to ',' for Dragon, though.
jeheydorn
commented
3 years ago I tried to work around this issue by installing the latest official release of Talon from https://talonvoice.com/dl/latest/talon-windows.exe, rather than use the older beta version I was previously on before trying to upgrade, but when I run it the officially released Talon, I'm getting these errors in talon_console.exe:
2020-11-18 10:06:45 ERROR user.knausj_talon.code.mouse (C:\Users\jheydorn\AppData\Roaming\talon\user\knausj_talon\code\mouse.py) import failed
17:
And these errors:
2020-11-18 10:06:45 WARNING lists: skipped because they have no matching declaration: (user.file_manager_directories, user.file_manager_files)
2020-11-18 10:06:45 WARNING lists: skipped because they have no matching declaration: (user.file_manager_directories, user.file_manager_files)
2020-11-18 10:06:45 WARNING settings: skipped because they have no matching declaration: (user.mouse_enable_pop_click, user.mouse_wake_hides_cursor, user.mouse_enable_pop_stops_scroll)
2020-11-18 10:06:46 ERROR cb error topic="update_speech" cb=<bound method SpeechSystem.update_grammars of <talon.scripting.speech_system.SpeechSystem object at 0x0000000008090188>>
34:
Talon commands are not working at all. Is there a particular git revision of knausj_talon anyone would recommend for use with the Talon official released? Any help would be appreciated.
rntz
commented
3 years ago hm, I'm not sure what's up with that. But, if you want a version of knausj that should allow punctuation in dictation and work with the latest talon beta (not the stable/official release, it's likely to have the same issue as what you just posted; EDIT: actually I'm not sure about this; see subsequent reply), you could try https://github.com/rntz/knausj_talon/commit/9ca9dfcb8016f366cf1d678c9d4706fadf3212ff. Let me know if that does or doesn't work for you. It's definitely a temporary solution, but the changes in that branch are likely to be incorporated into knausj soonish.
rntz
commented
3 years ago wait, actually, are you sure you're using the latest/a fairly recent knausj? the line that's erroring (the import in mouse.py) shouldn't exist in recent knausj versions, see https://github.com/knausj85/knausj_talon/blob/master/code/mouse.py for example.
So, all together, some options you could try that might work are:
jeheydorn
commented
3 years ago Yup, it turns out my knausj_talon repository was not up-to-date. I guess my git skills are getting rusty. Sorry for that trouble.
With the updated knausj_talon I'm still having the comma problem with version talon-windows-105-0.1.2-105-g5b1386b, but since the officially released version works fine, I'm just going to switch to that and not worry further about this issue.
lunixbochs
commented
3 years ago If 0.1.2-105 has the issue, public will have the issue in the future when 105 is released.
This was caused by an intentional change in the beta that fixes another issue where dragon made it impossible to insert some words. The solution is to map additional commands or do additional parsing or word replacement (such as s/comma/,/) in dictation mode after parse_words.
lunixbochs
commented
3 years ago I think this is fixed by the parse changes in latest beta via https://github.com/talonvoice/talon/issues/165 ?
knausj85
commented
3 years ago Yeah, this appears to be fixed in the latest beta.
knausj85
commented
3 years ago Fixed by Talon 0.1.3.
I just upgraded Talon beta to version talon-windows-105-0.1.2-105-g5b1386b, and I updated knausj_talon to revision 7b4aa7164eb3ccbde91d38eca86fcd019335ca11, and now when I dictate "comma" in dictation mode, it writes "comma" instead of ",". It didn't have this problem when I was on version talon-windows-89-0.0.8.29-1302-g082af90.
I tried removing all of my changes to knausj_talon to make sure they weren't causing a problem, but it didn't help. I also verified I'm not getting any errors when I run talon_consolel.exe.
I don't know why this is happening because dictation_mode.talon does have the rule to convert comma to ",":
(comma | kama): auto_insert(",")
I tried simplifying that to comma: auto_insert(",") but that didn't help.
I also tried adding a line in dictation_mode.talon just for testing, which converted the word fish to &, and it worked. I also verified that if I change that rule to use a different word, other than than comma, that other word will write a ",".
Comma works fine in command mode, meaning if I say comma, it writes ",".