talonvoice / beta

Issue tracker for the private Talon Beta
10 stars 0 forks source link

Jetbrains windows have empty string `.filename` #117

Closed dwiel closed 3 years ago

dwiel commented 3 years ago

Jetbrains windows have empty string for the filename:

actions.win.filename()
''

I can work around this for file extension detection using actions.win.title() for now.

dwiel commented 3 years ago

my current workaround:

ctx.matches = r"""
app: jetbrains
"""

@ctx.action_class("win")
class win_actions:
    def file_ext():
        return actions.win.title().split(".")[-1]
lunixbochs commented 3 years ago

This is not a talon bug, it's up to you to polyfill this kind of action in your user scripts for app specific cases exactly as you did here:

https://github.com/knausj85/knausj_talon/search?q=file_ext&unscoped_q=file_ext

dwiel commented 3 years ago

Got it, thanks. I had assumed it was a talon action, thanks for the clarification

On Mon, Sep 14, 2020, 8:49 PM Ryan Hileman notifications@github.com wrote:

Closed #117 https://github.com/talonvoice/beta/issues/117.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/talonvoice/beta/issues/117#event-3765914265, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAHGZQIF4B4G3KFZ3NLKHLSF223LANCNFSM4RMIYK3A .