search

talsalis / homebridge-miele-hood

Apache License 2.0
0 stars 8 forks source link

Error: Accessories must be created with a non-empty displayName. #6

Open c-fy opened 2 years ago

c-fy commented 2 years ago

I get an error after setting up the plugin and starting homebridge.

Error: Accessories must be created with a non-empty displayName. at new Accessory

The issue seems to be that Miele gives no data under devicename. User Quicksander had the same issues in his miele@home plugin and made "it robust against a possibly empty name" (see https://githubhot.com/repo/QuickSander/homebridge-mieleathome/issues/16 )

Is this fixable for this plugin too? Would be HIGHLY appreciated.

If there's anything I can do to assist, let me know.

Data from Miele Swagger /devices:

{ "000XXXXXXXXXX": { "ident": { "type": { "key_localized": "Gerätetyp", "value_raw": 18, "value_localized": "Dunstabzugshaube" }, "deviceName": "", "protocolVersion": 2, "deviceIdentLabel": { "fabNumber": "000XXXXXXXXX", "fabIndex": "11", "techType": "DA 6708 D", "matNumber": "XXXXXXXX", "swids": [ "4986", "20452", "25226" ] }, "xkmIdentLabel": { "techType": "EK039W", "releaseVersion": "02.72" } }, "state": { "ProgramID": { "value_raw": 0, "value_localized": "", "key_localized": "Programmbezeichnung" }, "status": { "value_raw": 5, "value_localized": "In Betrieb", "key_localized": "Status" }, "programType": { "value_raw": 0, "value_localized": "Programm", "key_localized": "Programmart" }, "programPhase": { "value_raw": 4608, "value_localized": "", "key_localized": "Programmphase" }, "remainingTime": [ 0, 0 ], "startTime": [ 0, 0 ], "targetTemperature": [ { "value_raw": -32768, "value_localized": null, "unit": "Celsius" } ], "temperature": [ { "value_raw": -32768, "value_localized": null, "unit": "Celsius" }, { "value_raw": -32768, "value_localized": null, "unit": "Celsius" }, { "value_raw": -32768, "value_localized": null, "unit": "Celsius" } ], "signalInfo": false, "signalFailure": false, "signalDoor": false, "remoteEnable": { "fullRemoteControl": false, "smartGrid": false, "mobileStart": false }, "ambientLight": null, "light": 1, "elapsedTime": [], "spinningSpeed": { "unit": "U/min", "value_raw": null, "value_localized": null, "key_localized": "Schleuderdrehzahl" }, "dryingStep": { "value_raw": null, "value_localized": "", "key_localized": "Trockenstufe" }, "ventilationStep": { "value_raw": 0, "value_localized": "", "key_localized": "Lüfterstufe" }, "plateStep": [], "ecoFeedback": null, "batteryLevel": null } },

QuickSander commented 2 years ago

Sorry,

I mistakenly replied to an issue on Talsalis’s repo.

Is there a reason you can’t use my plugin? (Not trying to advertise it, but in case Talsalis has no time and you want to continue)

Kind regards, Sander.

On 8 Mar 2022, at 00:57, c-fy @.***> wrote:

 If you do find some time and fix this, let me know where you want the bottle of whatever-you-like-to-drink-best shipped to! Honestly, having to use the Miele App bugs me since I have that hood. Been very excited to learn about your plugin a few days ago. If you get this running you‘ll be my hero! All the best! Chris

Sent from my iPhone

Am 07.03.2022 um 20:15 schrieb Sander @.***>:

 Thanks. This is certainly fixable. The thing is the hood code is copied and therefore uses a different code base. This is why the Hood code doesn't have this fix while other devices automatically receive this fix when the base code is changed.

I will see if I have some spare time in the weekend.

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you authored the thread. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.

QuickSander commented 2 years ago

"Should we delete the comments after my initial issue post to keep this clean?" I think so yes. I hope the other plugin works for you. If not, you can post an issue there.