search

talsec / Free-RASP-ReactNative

React Native plugin for improving app security and threat monitoring on Android and iOS mobile devices.
https://github.com/talsec/Free-RASP-Community
MIT License
91 stars 12 forks source link

Adding support for Expo SDK. #47

Closed asharamseervi closed 8 months ago

asharamseervi commented 9 months ago

Is your feature request related to a problem? Please describe. Those applications which is using ExpoSDK is dependent on build-config to change the minSdkVersion 23 as briefed in setup dependencies: https://www.npmjs.com/package/freerasp-react-native#step-2-set-up-the-dependencies.

Before ExpoSDK: [RUN_GRADLEW] > Task :app:processDebugMainManifest [RUN_GRADLEW] FAILED [RUN_GRADLEW] See https://developer.android.com/r/studio-ui/build/manifest-merger for more information about the manifest merger. [RUN_GRADLEW] /private/var/folders/fn/m4xr_x2s45gcfczl9txh02f80000gn/T/eas-build-local-nodejs/9a2469c8-7e79-4e02-9ad7-c3060e72ad53/build/android/app/src/debug/AndroidManifest.xml Error: [RUN_GRADLEW] uses-sdk:minSdkVersion 21 cannot be smaller than version 23 declared in library [:freerasp-react-native] /private/var/folders/fn/m4xr_x2s45gcfczl9txh02f80000gn/T/eas-build-local-nodejs/9a2469c8-7e79-4e02-9ad7-c3060e72ad53/build/node_modules/freerasp-react-native/android/build/intermediates/merged_manifest/debug/AndroidManifest.xml as the library might be using APIs not available in 21 [RUN_GRADLEW] Suggestion: use a compatible library with a minSdk of at most 21, [RUN_GRADLEW] or increase this project's minSdk version to at least 23, [RUN_GRADLEW] or use tools:overrideLibrary="com.freeraspreactnative" to force usage (may lead to runtime failures) [RUN_GRADLEW] FAILURE: Build failed with an exception. [RUN_GRADLEW] * What went wrong: [RUN_GRADLEW] Execution failed for task ':app:processDebugMainManifest'. [RUN_GRADLEW] > Manifest merger failed : uses-sdk:minSdkVersion 21 cannot be smaller than version 23 declared in library [:freerasp-react-native] /private/var/folders/fn/m4xr_x2s45gcfczl9txh02f80000gn/T/eas-build-local-nodejs/9a2469c8-7e79-4e02-9ad7-c3060e72ad53/build/node_modules/freerasp-react-native/android/build/intermediates/merged_manifest/debug/AndroidManifest.xml as the library might be using APIs not available in 21 [RUN_GRADLEW] Suggestion: use a compatible library with a minSdk of at most 21, [RUN_GRADLEW] or increase this project's minSdk version to at least 23, [RUN_GRADLEW] or use tools:overrideLibrary="com.freeraspreactnative" to force usage (may lead to runtime failures) [RUN_GRADLEW] * Try: [RUN_GRADLEW] > Run with --stacktrace option to get the stack trace. [RUN_GRADLEW] > Run with --info or --debug option to get more log output. [RUN_GRADLEW] > Run with --scan to get full insights. [RUN_GRADLEW] * Get more help at https://help.gradle.org [RUN_GRADLEW] BUILD FAILED in 1m 7s

Describe the solution you'd like Expo is widely accepted by the React Native Community and may open a gateway for mass adoption. I hope the team will accept my sincere request to support Expo.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

msikyna commented 9 months ago

Hello @asharamseervi ,

thank you for reporting the issue. We will look at it.

Kind regards, Talsec team

tompsota commented 9 months ago

Hi @asharamseervi,

try to increase minSdkVersion to 23. This is a requirement of the freerasp.

In expo app, this can be done with expo-build-properties plugin: https://docs.expo.dev/versions/latest/sdk/build-properties/.

We'll also add this into documentation.

Let us know it this helped.

Cheers, Tomas, Talsec developer