search

talsma-ict / context-propagation

Propagate snapshots of ThreadLocal values to another thread
Apache License 2.0
19 stars 8 forks source link

Bump org.apache.logging.log4j:log4j-api from 2.23.1 to 2.24.1 #491

Closed dependabot[bot] closed 1 month ago

dependabot[bot] commented 2 months ago

Bumps org.apache.logging.log4j:log4j-api from 2.23.1 to 2.24.1.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
sjoerdtalsma commented 2 months ago

@Marcono1234 It seems the fix for https://github.com/apache/logging-log4j2/issues/2946 doesn't fix our tests, could you please take a look?

Error:  Tests run: 18, Failures: 9, Errors: 0, Skipped: 0
Marcono1234 commented 1 month ago

It looks like that Log4j 2 issue was not fully fixed, see https://github.com/apache/logging-log4j2/issues/2946#issuecomment-2382637836 (and subsequent comments and linked pull request).

Would it be ok for you to again wait for the next Log4j 2 release? I hope this dependency update here is not urgent.

sjoerdtalsma commented 1 month ago

Sure, we’ll wait for the next patch version. Thanks a lot for looking into the problem!

sjoerdtalsma commented 1 month ago

Skip this version and wait for the next patch version.

dependabot[bot] commented 1 month ago

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

Marcono1234 commented 1 month ago

It seems this was unrelated to the above mentioned Log4j 2 issue, and can already be fixed: #498