search

tamzinblake / js3-mode

A chimeric fork of js2-mode and js-mode
GNU General Public License v3.0
180 stars 13 forks source link

Maintainer wanted #100

Open tamzinblake opened 10 years ago

tamzinblake commented 10 years ago

It would be great if someone else could maintain js3-mode. I think most people use the well-maintained js2-mode, but a bunch of people prefer js3-mode so it would be nice if someone were keeping up with it. I wouldn't say I've abandoned the project, but I have a lot of higher-priority stuff going on, so I'm willing to pass it along to an interested party.

plumlee commented 10 years ago

I use this every single day, and would be willing to help out. My lisp is pretty poor, but I’m willing to learn. I can start doing taking on some issues and see how I do, then you can make a decision as to whether you’d be comfortable with me taking over in the future.

tamzinblake commented 10 years ago

coolio

plumlee commented 10 years ago

Sorry this has taken me so long to circle back to. Family stuff has been piling on, but I can start some actual issue addressing in October if you're still looking for someone to take over.

marcinant commented 10 years ago

Don't you think that merging js3 unique features to js2 would be the best option?

tamzinblake commented 10 years ago

I'm pretty sure the js2-mode folks don't like js3-mode's approach to indentation - it breaks indenting the whole buffer and can take a long time on large JS files. So I doubt that core feature will make it into js2-mode. If developing that to the part where it works better is possible, maybe that could make it in, but I suspect that would require a major rewrite to the JS parser, which would probably make it substantially different from js2-mode.

That said, it's open-source, so do whatever.

dgutov commented 10 years ago

I'm pretty sure the js2-mode folks don't like js3-mode's approach to indentation - it breaks indenting the whole buffer and can take a long time on large JS files.

You don't have to get your indentation mechanism into js2-mode to reuse most of its benefits. I'm going to switch to using the indentation code from js-mode anyway, after Emacs 24.4 is released.

What you can do, though, is make js3-mode inherit from js2-mode and set indent-line-function to yours. That way you'll benefit from any parser improvements automatically, and will also be able to use this major mode with skewer-mode and friends.

Although, like discussed before, I'd prefer if you started with choosing a more neutral name.

tamzinblake commented 8 years ago

bump