Manipulating team members results in GitHubClientException with HTTP Code 422 - Githubissues

tan-tan-kanarek / github-php-client

MIT License

184 stars 120 forks source link

Manipulating team members results in GitHubClientException with HTTP Code 422 #103

Closed torunar closed 8 years ago

torunar commented 8 years ago

The issue probably occurs because the deprecated members API is used in

getTeamMember(): https://github.com/tan-tan-kanarek/github-php-client/blob/master/client/services/GitHubOrgsTeams.php#L90
addTeamMember(): https://github.com/tan-tan-kanarek/github-php-client/blob/master/client/services/GitHubOrgsTeams.php#L98
removeTeamMember(): https://github.com/tan-tan-kanarek/github-php-client/blob/master/client/services/GitHubOrgsTeams.php#L117

Accordingly to https://developer.github.com/v3/orgs/teams/, /memberships/ should be used instead of /members/ and response codes are different.

tan-tan-kanarek commented 8 years ago

Thank you for your comment. Would you be able to change it, test it and pull request it?

torunar commented 8 years ago

@tan-tan-kanarek, sure: https://github.com/tan-tan-kanarek/github-php-client/pull/104