search

tango-controls / cppTango

Moved to gitlab
http://tango-controls.org
41 stars 34 forks source link

Rework static/shared variants into a configure-time build-switch (#688) #827

Closed t-b closed 2 years ago

t-b commented 3 years ago

Shared/static switching on windows

configure/CMakeLists.txt: Don't link against msvcstub anymore on windows

We don't link against that library from omniorb anymore as it is only needed as a workaround for using ominORB DLLs under MSVC++ 5.0 (due to destructor inlining issues).

Co-authored-by: Marius Elvert marius.elvert@softwareschneiderei.de

Close #826

beenje commented 3 years ago

I see that CI failed but I managed to build this branch on windows using conda-build (with only a patch to rename the libzmq and pthread libraries according to existing conda packages). I didn't run any tests.

t-b commented 3 years ago

@beenje Thanks for trying. I think I fixed the build error. It was in appveyor.yml.

beenje commented 3 years ago

@beenje Thanks for trying. I think I fixed the build error. It was in appveyor.yml.

OK. If that's the only file you modified, that will not change anything for the conda build. I can still double check when the CI passes if you want.

t-b commented 3 years ago

@mliszcz @bourtemb Ready.