tangrams / tangram

WebGL map rendering engine for creative cartography
https://tangram.city
MIT License
2.22k stars 290 forks source link

fix task time tracking #649

Closed meetar closed 6 years ago

meetar commented 6 years ago

@bcamper Suggesting these changes in response to https://github.com/tangrams/tangram/issues/646 – it seems as though there are fewer problems with missing sprites in the Differ with this change (though it doesn't solve all the problems) … Is it possible these variables were set incorrectly?

bcamper commented 6 years ago

Hmm, I don't think those lines are wrong (though it's possible something else with task time tracking is): the this. vars track the total task execution time for all tasks this frame. The task. ones track time on individual tasks. A new task is only started if the total frame time is under the allowed max.

I suspect some other sync issue with the Differ not knowing the proper frame completion state. Could be that tracking of completion is wrong, or the logic for firing the event isn't right, or how it's being measure/interacted with by Differ is wrong. I guess more examples of how to reproduce and, if possible, a reliable one that always produces the same results would be of great help (I don't think I could ever get that for this and I gave up and did the release anyway)

meetar commented 6 years ago

It looks like the task is just never starting, I narrowed it down to a standalone (non-Differ) case here: https://github.com/tangrams/tangram/issues/646#issuecomment-395192407

bcamper commented 6 years ago

Root cause resolved in https://github.com/tangrams/tangram/issues/646#issuecomment-441479823 🎉