search

taocpp / PEGTL

Parsing Expression Grammar Template Library
Boost Software License 1.0
1.95k stars 229 forks source link

Validate PEGTL tests when no filesystem is configured #351

Closed uilianries closed 1 year ago

uilianries commented 1 year ago

I merged the PR #350 to a new branch created from 3.x, and added a new new validation in Actions to check that we don't break tests when running without filesystem.

The filesystem has a specific test test_filesystem.cpp.in that should be activated only when PEGTL_USE_FILESYSTEM is active. So this new regression test checks in case we break something when changing filesystem.

Related to #350

ColinH commented 1 year ago

Great, thanks, you can merge this in to the 3.x branch when you think it's ready, and I'll take care of removing the change and boost::filesystem support from the main branch RSN.

uilianries commented 1 year ago

@ColinH I see Github Action is failing due missing compilers. I'll take a look on this. It seems like the latest version of Ubuntu distributed by Github does not support older compiler versions.

codecov-commenter commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (cf639f7) 99.70% compared to head (191fe2e) 99.70%.

:exclamation: Current head 191fe2e differs from pull request most recent head 86a677a. Consider uploading reports for the commit 86a677a to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 3.x #351 +/- ## ======================================= Coverage 99.70% 99.70% ======================================= Files 248 250 +2 Lines 5045 5096 +51 ======================================= + Hits 5030 5081 +51 Misses 15 15 ``` [see 16 files with indirect coverage changes](https://app.codecov.io/gh/taocpp/PEGTL/pull/351/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=taocpp)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

uilianries commented 1 year ago

Clang Tidy failed, but I'll ignore it for now, as it could be customized.