taoensso / sente

Realtime web comms library for Clojure/Script
https://www.taoensso.com/sente
Eclipse Public License 1.0
1.74k stars 194 forks source link

Do not add a beforeunload event listener when running inside NodeJS #453

Closed theasp closed 1 month ago

theasp commented 2 months ago

This solves this problem:

SHADOW import error /home/asp/projects/xxx/.shadow-cljs/builds/server/dev/out/cljs-runtime/taoensso.sente.js

/home/asp/projects/xxx/target/private/js/server.js:64
  /* ignore this, look at stacktrace */ fn.call(global, require, module, __filename, __dirname);
                                           ^
TypeError: goog.global.addEventListener is not a function
    at /home/asp/projects/xxx/.shadow-cljs/builds/server/dev/out/cljs-runtime/taoensso/sente.cljc:1353:4
    at global.SHADOW_IMPORT (/home/asp/projects/xxx/target/private/js/server.js:64:44)
    at /home/asp/projects/xxx/target/private/js/server.js:1624:1
    at Object.<anonymous> (/home/asp/projects/xxx/target/private/js/server.js:1638:3)
    at Module._compile (node:internal/modules/cjs/loader:1233:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1287:10)
    at Module.load (node:internal/modules/cjs/loader:1091:32)
    at Function.Module._load (node:internal/modules/cjs/loader:938:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:83:12)
    at node:internal/main/run_main_module:23:47
ptaoussanis commented 2 months ago

@theasp Thanks for this Andrew! Any urgency from your end for a new release, or could it wait a few weeks while I finish up some other stuff?

theasp commented 2 months ago

Hi Peter,

No urgency on my part, take your time. I didn't even notice for over a year!

ptaoussanis commented 1 month ago

Merging manually now, thanks again Andrew!