Various bugs - Githubissues

b3n4kh commented 11 months ago

[x] Assess: scroll down (to have new items loaded), offset in URL changes. Then one opens a newsItem, then press "back" in browser. The Assess is loaded with the offset. This could be considered as a feature but in the UI the offset is not manageable so one has to remove the offset from the URL to get the full view - it feels a bit off
[x] Assess > Open detail view > toggle twice the top left button > go back (or go to Assess/Dashboard) - visible frontend regressions in Assess, Dashboard
[x] Login: why is a reload needed when the JWT token expires
[x] Assess: Compact view increases the height of story item cards (adds a white border to the bottom) in non-full screen mode
[x] Analyze: New Report -> Disinformation -> Summary -> Date: frontend regression
[x] Assess: cluster a story manually -> click "relevance" -> edit the story (press Update) -> click Assess = relevance is still clicked, however, the URL is reset to default /assess and the view is not sorted by relevance (order seems not to be kept correctly as expected via caching)
[x] Infinite scroll needs inspection, it sometimes avoids rendering more items
[x] Collector preview: toggle left menu button active - should be disabled
[ ] New Assess Cache feature: if new sources are collected, Assess needs reload
[ ] When frontend error/success message is displayed, and page is reloaded, timer on the error is poped up as a new message
[ ] Admin: osint sources - at the menu bar "all items" / "displayed" items show the same number (shows incorrect count of items displayed)
[ ] Edit Story: the tags combobox has a dropdown, but unchecking the item makes the item disappear completely. Seems like a bad UX, removing the dropdown would be an option
[ ] Assess: (only frontend issue) filter set to "not read"+"not important", (preferably filter out one item) -> mark as read (last item needs to be marked as read twice for successful "marking as read" operation)
[ ] Assess: Bug still present!: If story is "selected", filter changes, Story previously selected and not visible is still selected
[ ] Assess: Add the same item multiple times to a report, before refresh, the arrow signaling the item is in a report is there again and again, it should only be there once
[ ] Assess: Date filter > select a date > the tool tip stays visible, however it should disappear

[ ] space for improvement of error handling

[Core] [DEBUG] - Grouping Stories Failed - 'str' object has no attribute 'pop'
[Core] [DEBUG] - Traceback (most recent call last):
File "/home/<username>/git/taranis-ai/src/core/core/model/story.py", line 668, in group_stories
first_story = Story.get(story_ids.pop(0))
                        ^^^^^^^^^^^^^
AttributeError: 'str' object has no attribute 'pop'

Possible improvements:

[ ] Administration: When you are in eg. OSINTSources (in admin view) and click "Administration", the OSINTSources card stays clicked.
[ ] When adding report types and its attributes, if name of an attribute is left blank, we could fallback to the "attribute" name itself
[ ] Add the possibility to delete selected stories and/or articles at once with selection (similar how we merge stories)
[ ] Administration: Product types: Behaviour seems off to me. When coming from a product type already open, creating a new one, it prefills the Content field with the previous item's Content. One can't create a custom product type without picking a Type (Even though, the DB is not set to reject NULL values).
[ ] Administration: Word Lists: > New Item > A not great error message thrown ("At least one usage must be chosen"), when in reality, no clear field "Usage" is present, Can we make this better? (maybe "... one checkbox needs to be chosen"???)
[ ] Improve error messages while importing OSINTSources