#39: Do not try to install mosquitto binary in /sbin on MacOS

tarantool / mqtt

Tarantool MQTT client

tarantool.org

BSD 2-Clause "Simplified" License

39 stars 10 forks source link

#39: Do not try to install mosquitto binary in /sbin on MacOS #40

Closed akudiyar closed 4 years ago

akudiyar commented 4 years ago

Fixes #39 Tested on my mac:

a.kuzin@a:~/sources/tarantool/mqtt$ ls -l /usr/local/sbin
a.kuzin@a:~/sources/tarantool/mqtt$ ls -l /usr/local/bin | grep mosq
-rwxr-xr-x   1 a.kuzin  admin  261972 27 апр 10:55 mosquitto
-rwxr-xr-x   1 a.kuzin  admin   29660 27 апр 10:55 mosquitto_passwd
-rwxr-xr-x   1 a.kuzin  admin   59392 27 апр 10:55 mosquitto_pub
-rwxr-xr-x   1 a.kuzin  admin   59768 27 апр 10:55 mosquitto_rr
-rwxr-xr-x   1 a.kuzin  admin   59040 27 апр 10:55 mosquitto_sub

Totktonada commented 4 years ago

Two general comments:

I observed the issue #39 on Linux, not Mac OS.
Right this to do would be link with libmosquitto statically (when packaging) rather than deploy it as part of tarantool-mqtt package within separate .so / .dylib, because a system may have its own libmosquitto library. It should be controlled by a cmake option.

akudiyar commented 4 years ago

I agree, the second option could solve #41 as well