search

tardis-sn / stardis

TARDIS stellar radiative transfer
https://tardis-sn.github.io/stardis/
11 stars 15 forks source link

Fix NaNs for cool atmospheres with H2+BF and H-FF opacities enabled. #219

Closed jvshields closed 1 month ago

jvshields commented 1 month ago

Our H2+ bound-free opacity table has a lower temperature bound of 3150 K, a temperature that is reasonably achievable in the outermost layers of cool stellar atmospheres. Scipy's LinearNDInterpolator defaults to nan, outside of the convex hull that it spans, which propagates to all of our opacities, and in turn to all of the fluxes. This PR changes that behavior to just assume that H2+ BF opacity does not contribute at these low temperatures, which isn't exactly physical but is better than the previous behavior of just not being able to run cool simulations with this opacity source turned on.

Also applies the same patch to H- FF opacity.

andrewfullard commented 1 month ago

Given the non-physical nature of this change, I think raising a warning would be appropriate

jvshields commented 1 month ago

Given the non-physical nature of this change, I think raising a warning would be appropriate

I've added a logger warning for this.