tari-project / tari

The Tari protocol
https://tari.com
BSD 3-Clause "New" or "Revised" License
350 stars 218 forks source link

feat: clear handshake error when connections go stale #6528

Closed hansieodendaal closed 1 month ago

hansieodendaal commented 1 month ago

Description

Cleared handshake error form the client side by forcefully disconnecting form the peer.

Motivation and Context

This is to syop the phenomenon whereby a peer can dial another peer (dial-eer XXXXX) but cannot ping that same peer (ping-peer XXXXX). (See #6516)

How Has This Been Tested?

Unit tests pass Long-term system-level testing has to be done to confirm this solved the issue.

What process can a PR reviewer use to test or verify this change?

Review code changes.

Breaking Changes

github-actions[bot] commented 1 month ago

Test Results (CI)

    3 files    129 suites   40m 25s :stopwatch: 1 308 tests 1 306 :white_check_mark: 0 :zzz: 2 :x: 3 910 runs  3 908 :white_check_mark: 0 :zzz: 2 :x:

For more details on these failures, see this check.

Results for commit a03e99aa.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 1 month ago

Test Results (Integration tests)

36 tests  +36   36 :white_check_mark: +36   16m 8s :stopwatch: + 16m 8s 11 suites +11    0 :zzz: ± 0   2 files   + 2    0 :x: ± 0 

Results for commit a03e99aa. ± Comparison against base commit 14a6631b.

:recycle: This comment has been updated with latest results.