Fix bug where dev repo urls ending with a "/" would result in `opam monorepo pull` placing package source code directly inside the duniverse directory instead of in a subdirectory of the duniverse directory

tarides / opam-monorepo

Assemble dune workspaces to build your project and its dependencies as a whole

ISC License

130 stars 27 forks source link

Fix bug where dev repo urls ending with a "/" would result in `opam monorepo pull` placing package source code directly inside the duniverse directory instead of in a subdirectory of the duniverse directory #359

Closed gridbugs closed 1 year ago

gridbugs commented 2 years ago

I've updated the code based on feedback but I haven't written any more tests yet. Will do tomorrow.

gridbugs commented 1 year ago

Added tests for cases where dev_repos fail to parse into names. I also hit a bug where String.drop_suffix was returning its argument unchanged when the suffix and the string were equal which I've fixed and added tests that it behaves as expected.

Leonidas-from-XIV commented 1 year ago

LGTM! :)