tarides / opam-monorepo

Assemble dune workspaces to build your project and its dependencies as a whole
ISC License
130 stars 27 forks source link

Handle dune files in vendored packages #370

Closed Leonidas-from-XIV closed 1 year ago

Leonidas-from-XIV commented 1 year ago

Menhir ships with vendored_pprint (and vendored_fix) which are used in the rest of Menhir, but at the moment these get renamed, while the reference to them does not, so the build fails as the Menhir dune files refer to vendored_pprint while the public_name is vendored_pprint.<hash> and only the non-public name is vendored_pprint (but that name is not exposed outside of the vendored_pprint package).

TL;DR: opam-monorepo changes references from public_names to private names, but that rename operation is not always valid.