search

tasdikrahman / vocabulary

[Not Maintained anymore] Python Module to get Meanings, Synonyms and what not for a given word
https://vocabulary.readthedocs.io/en/latest/
MIT License
560 stars 76 forks source link

timeouts #60

Open blissend opened 6 years ago

blissend commented 6 years ago

How are they dealt with?

Looking at https://github.com/tasdikrahman/vocabulary/blob/9d8870c7ba3678b88850ea1c82ff5b9cbacce47a/vocabulary/vocabulary.py#L89 for example doesn't show any setting for it. Would it be possible to add one considering http://docs.python-requests.org/en/master/user/quickstart/#timeouts states it could hang indefinitely?

tasdikrahman commented 6 years ago

How are they dealt with?

As of now, they are not being dealt with. But it's definitely a good to have feature for more robustness.

Would it be possible to add one considering

I would love for contributions from others :)

blissend commented 6 years ago

I would love for contributions from others :)

I thought about it but I prefer using a class configurable variable (self) which would go against the design in place (staticmethods). :(