search

taskcluster / remotely-signed-s3

A library and tool designed to support doing Amazon S3 uploads and downloads with request signing occuring on a different machine than the machine performing the actual upload or download.
Mozilla Public License 2.0
0 stars 3 forks source link

Faster install tests and updates #10

Closed jhford closed 5 years ago

jhford commented 5 years ago

Fix problems with tests. There's two major changes here:

  1. support session key for temporary aws credentials
  2. use non-vhost addressing for tests. We have substantial coverage for generating requests for the vhost case, but for macs this allows us to not need to add to the hosts file.
jhford commented 5 years ago

(I've verified this works locally, so if it fails on travis it's due to an absence of aws credentials)

jhford commented 5 years ago

@imbstack I'm asking for review even though travis isn't working. I'm not sure how we put aws credentials into travis these days now that we have requiremfa. I can verify that these tests work with a local AWS temporary credential.

djmitche commented 5 years ago

I created an IAM user and added its credentials to Travis. What credentials was it using before? Hopefully not your own! :)