taskcluster / taskgraph

Generates task dependency graphs for Taskcluster CI
Mozilla Public License 2.0
16 stars 42 forks source link

Remove useless tasks list allocation in `transforms.docker_image` #565

Closed Eijebong closed 3 months ago

Eijebong commented 3 months ago

This was allocating a list of tasks from the passed in tasks generator before iterating over it. The reason this was here is because when that code got imported into this repo, (see be320c2b3a22c03d5fe7583f761456f75267c9b0), it was reordering the tasks before iterating over them. Said reordering got removed in ff0097edea821f8bab8ac9975f3ffc740956d683 but the allocation stayed.

I'm not expecting this to have any impact whatsoever but it confused me and ended up being useless so we might as well remove it.