In #591 I implemented a new function should_repack_archive that aimed to improve the robustness of renaming files while preserving the preexisting logic of when to repack an archive in a fetch task.
Unfortunately, I left an outer if-statement that leaves one edge case in which the behavior is slightly changed.
Whenever args.strip_components or args.add_prefix is defined, we are supposed to repack the archive regardless, however the new logic stays to do it only if the files are not the same.
The logic is correct within the new function, but the outer if-statement needs to be removed.
In #591 I implemented a new function should_repack_archive that aimed to improve the robustness of renaming files while preserving the preexisting logic of when to repack an archive in a fetch task.
Unfortunately, I left an outer if-statement that leaves one edge case in which the behavior is slightly changed.
Whenever
args.strip_componentsorargs.add_prefixis defined, we are supposed to repack the archive regardless, however the new logic stays to do it only if the files are not the same.The logic is correct within the new function, but the outer if-statement needs to be removed.