search

tatsuhiro-t / spdylay

The experimental SPDY protocol version 2, 3 and 3.1 implementation in C
http://tatsuhiro-t.github.io/spdylay/
MIT License
603 stars 102 forks source link

shrpx: Support for SHOUTcast (ICY) Protocol #93

Closed berstend closed 10 years ago

berstend commented 10 years ago

Hi,

shrpx doesn't seem to like shoutcast radio streams: http://6mediaserver.de:8000/;?stream.mp3

AFAIK the ICY protocol is violating HTTP specs:

 ⚡ ~ wget --save-headers --proxy=off -nd http://wcic-sc.streamguys.us/\;stream/1
--2013-11-10 00:36:53--  http://wcic-sc.streamguys.us/;stream/1
Resolving wcic-sc.streamguys.us (wcic-sc.streamguys.us)... 66.225.205.50
Connecting to wcic-sc.streamguys.us (wcic-sc.streamguys.us)|66.225.205.50|:80... connected.
HTTP request sent, awaiting response... 200 No headers, assuming HTTP/0.9
Length: unspecified
Saving to: ‘1’

    [                <=>                                                                                                                                                                               ] 324.815     39,2KB/s

Thank you.

tatsuhiro-t commented 10 years ago

The problem is we use joyent/http-parser, which is strict for HTTP-version string. We patched it and allow custom HTTP-version string. Fix committed in a3828ee