vendor js loaded after route assets

tattersoftware / codeigniter4-assets

Asset handling for CodeIgniter 4

MIT License

50 stars 12 forks source link

vendor js loaded after route assets #4

Closed rodolfodn closed 4 years ago

rodolfodn commented 4 years ago

MGatner commented 4 years ago

I’ll take a look. User routes should definitely take precedence (e.g. load after) vendor assets.

rodolfodn commented 4 years ago

I've fixed. But I don't know why I can't make a separated pull request from the other one.

The issue was on Assets.php line 173. The array merge was inverted.

MGatner commented 4 years ago

When making pull requests you should make your own local branch (like “bugfix-locale”) and apply your commits there so when you want to make a second PR you can branch off the unmodified develop again.

I’ve merged your first PR so feel free to submit another now if you have it. Thank you for the work.

rodolfodn commented 4 years ago

Thanks! The fix for this one is on the merge already. You can close the issue.