tauri-apps / tauri-docs

The source for all Tauri project documentation.
https://tauri.app
MIT License
834 stars 633 forks source link

migrate i18n-tracker to Lunaria, closed #2853 #2976

Closed GuoJikun closed 1 week ago

GuoJikun commented 2 weeks ago

Description

closes #2853

netlify[bot] commented 2 weeks ago

Deploy Preview for tauri-v2 ready!

Built without sensitive environment variables

Name Link
Latest commit b686d814e6b1957298244d0ef7643b079db15222
Latest deploy log https://app.netlify.com/sites/tauri-v2/deploys/673e9d4ff6871b0008981f80
Deploy Preview https://deploy-preview-2976--tauri-v2.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance: 99 (๐Ÿ”ด down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

socket-security[bot] commented 2 weeks ago

New and removed dependencies detected. Learn more about Socket for GitHub โ†—๏ธŽ

Package New capabilities Transitives Size Publisher
npm/@lunariajs/core@0.1.1 Transitive: environment, filesystem, shell, unsafe +31 4.85 MB yanthomasdev
npm/@lunariajs/starlight@0.1.1 None 0 8.96 kB yanthomasdev

๐Ÿšฎ Removed packages: npm/@types/html-escaper@3.0.2, npm/dedent-js@1.0.1, npm/node-fetch@3.3.2, npm/p-retry@6.2.1

View full reportโ†—๏ธŽ

GuoJikun commented 2 weeks ago

@vasfvitor How to get GITHUB_TOKEN for environment in packages/lunaria/renderer.config.ts

vasfvitor commented 2 weeks ago

related: https://github.com/tauri-apps/tauri-docs/pull/1854/files

@vasfvitor How to get GITHUB_TOKEN for environment in packages/lunaria/renderer.config.ts

Do we really need that to setup Lunaria? I think we can get rid of the external package and use Lunaria directly into the docs main package as an astro integration and just make a few config to mantain the same route instead of /lunaria, or is there any reason you did that way?

...and I can't create and manage tokens. If you still need to to know more about token, please tag FabianLars, not tagging him now because I'm not sure we will really need. Either way you can tag me again so we can bring this live. Thanks

GuoJikun commented 2 weeks ago

I think we can get rid of the external package and use Lunaria directly into the docs main package as an astro integration and just make a few config to mantain the same route instead of /lunaria

The Lunaria-related configuration has been moved to the main package

image this module need Github Token

GuoJikun commented 2 weeks ago

I created a pr months ago to add Lunaria to this repo, dunno if it helps as ref, btw you might also need to test this removing the i18ntracker package.

The "NeedReview" module has no content yet because I don't know how to get the 'GITHBB_TOKEN'. Your PR has been referenced. i18ntracker is removed.

vasfvitor commented 1 week ago

@tweidinger would you approve the _headers modification? just to ensure there's no pitfall on this setting https://github.com/tauri-apps/tauri-docs/pull/2976/files#diff-36e1aa26d55b829e1d4d1cc909c9c9d34972deeedf4ad4d631e5bff6842887d4

FabianLars commented 1 week ago

can we revert the formatting changes of the headers file? ๐Ÿ˜… looks kinda broken even if it still works.

FabianLars commented 1 week ago

LGTM, hope this doesn't break anything ๐Ÿซก

That would be super boring ๐Ÿ˜