tauri-apps / tauri

Build smaller, faster, and more secure desktop and mobile applications with a web frontend.
https://tauri.app
Apache License 2.0
85.73k stars 2.59k forks source link

enhance: include the path in ACL I/O errors #11575

Closed kornelski closed 3 weeks ago

kornelski commented 3 weeks ago

Errors about files missing that don't include the file path are difficult to diagnose:

failed to read plugin permissions: failed to read file: No such file or directory (os error 2)

I've added paths to ACL's I/O errors.

FabianLars commented 3 weeks ago

Thanks! I agree that this would be a valuable change but since it's exposed here https://docs.rs/tauri-utils/latest/tauri_utils/acl/enum.Error.html it would technically be a breaking change 🤔 @amrbashir any idea how to handle this?

p.s. we also need a change file before we can merge this

github-actions[bot] commented 3 weeks ago

Package Changes Through 2c1d1421516d522124e0e340affc1d728f54a7a6

There are 8 changes which include tauri with minor, tauri-bundler with patch, tauri-cli with patch, @tauri-apps/cli with patch, tauri-runtime-wry with patch, @tauri-apps/api with patch, tauri-utils with minor, tauri-runtime with patch

Planned Package Versions The following package releases are the planned based on the context of changes in this pull request. | package | current | next | |----|----|----| | @tauri-apps/api | 2.0.3 | 2.0.4 | tauri-utils | 2.0.2 | 2.1.0 | tauri-bundler | 2.0.4 | 2.0.5 | tauri-runtime | 2.1.1 | 2.1.2 | tauri-runtime-wry | 2.1.2 | 2.1.3 | tauri-codegen | 2.0.2 | 2.0.3 | tauri-macros | 2.0.2 | 2.0.3 | tauri-plugin | 2.0.2 | 2.0.3 | tauri-build | 2.0.2 | 2.0.3 | tauri | 2.0.6 | 2.1.0 | @tauri-apps/cli | 2.0.4 | 2.0.5 | tauri-cli | 2.0.4 | 2.0.5 |

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

amrbashir commented 3 weeks ago

This shouldn't be a breaking change since the acl module is marked as instable, see https://docs.rs/tauri-utils/latest/tauri_utils/acl/index.html#stability

FabianLars commented 3 weeks ago

ah didn't see that, cool