tavalin / orvibo-sdk

Java SDK for Orvibo devices
MIT License
11 stars 5 forks source link

Add support for AllOne IR Blaster #15

Open ThomDietrich opened 7 years ago

ThomDietrich commented 7 years ago

Hey @tavalin, I found this sdk through the addon for openHAB. I wanted to ask if you are going to integrate the IR Blaster in the near future? It seems to me like the socket and the blaster are the two famous products by Orvibo and it's a shame your addon only supports the one.

I'm sure you know about the IR Blaster, here is an article on it. There is a library linked, which should contain the needed technical details. https://community.openhab.org/t/orvibo-allone-ir-blaster-guide/9111

I would "buy you a beer" if you found the time to extend your sdk/addon!

tavalin commented 7 years ago

Hey @ThomDietrich

Good news...

I've already added AllOne functionality to the library and built a beta version of the OH2 binding. You can view my post in the OH forum from June where I mentioned it.

Unfortunately:

  1. I don't own an AllOne so I'm unable to test on real hardware, I'm reliant on testers...
  2. I only had feedback from one person that used it (seemed to work OK for them)

So give it a go and let me know your findings.

ThomDietrich commented 7 years ago

Oh! nice ;) You need to give me a few days but I'll look into it! The method to save the IR pattern to a file seems oddly complicated. Do you agree it would be more practical to encode the data to a human readable String? The binding could write this string to a String item and the user could work with it in a rule. One step further, this string could be used in the channel definition of an item.

Do you by any chance live in Germany? I could lend my device to you.

tavalin commented 7 years ago

Nope, unfortunately I'm in the UK.

The idea for saving the IR code to a file instead of an OH2 String item seemed sensible. However if you wish to discuss further could you open the issue on my OH2 fork please?

tavalin commented 7 years ago

@ThomDietrich I haven't forgotten about this, but I'm trying to improve some of the core networking/messaging code which this should eventually benefit from.