Set the baseurl in the constructor, and make it filterable - Githubissues

taxjar / taxjar-woocommerce-plugin

WooCommerce Sales Tax Plugin by TaxJar

http://www.taxjar.com/woocommerce-sales-tax-plugin/

GNU General Public License v2.0

30 stars 29 forks source link

Set the baseurl in the constructor, and make it filterable #185

Open boblinthorst opened 3 years ago

boblinthorst commented 3 years ago

Describe the problem (reference the issue if applicable) and what the PR accomplishes.

https://github.com/taxjar/taxjar-woocommerce-plugin/issues/184

In this PR, I make the baseUrl filterable, so that the baseurl can be changed to https://api.sandbox.taxjar.com.

Steps to Reproduce

Do this
And that
Finally this

Expected Result

After applying the PR, this should happen.

Click-Test Versions

[ ] Woo 4.0
[ ] Woo 3.9
[ ] Woo 3.8
[ ] Woo 3.7
[ ] Woo 3.6
[ ] Woo 3.5
[ ] Woo 3.4
[ ] Woo 3.3
[ ] Woo 3.2
[ ] Woo 3.1
[ ] Woo 3.0

Specs Passing

[ ] Woo 4.0
[ ] Woo 3.9
[ ] Woo 3.8
[ ] Woo 3.7
[ ] Woo 3.6
[ ] Woo 3.5
[ ] Woo 3.4
[ ] Woo 3.3
[ ] Woo 3.2
[ ] Woo 3.1
[ ] Woo 3.0

CLAassistant commented 2 years ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}