tazz4843 / whisper-rs

Rust bindings to https://github.com/ggerganov/whisper.cpp
The Unlicense
695 stars 110 forks source link

Expose whisper.cpp version as a static string #172

Closed sagebind closed 2 months ago

sagebind commented 2 months ago

Add a WHISPER_CPP_VERSION static that contains the version number of whisper.cpp that whisper-rs was built with. This can be useful for downstream applications for debugging and logging purposes.

This is implemented using build script metadata for whisper-rs-sys to expose the version number of whisper.cpp defined in CMakeLists.txt as metadata to crates that depend on it. Then whisper-rs accesses that build metadata and defines its own internal compile-time environment variable containing the same value, which is then assigned to a static variable.

It seemed better to expose this information through build metadata rather than defining a static in whisper-rs-sys directly, despite the extra indirection, so as to keep whisper-rs-sys as pure bindings.

sagebind commented 2 months ago

Just needs a cargo fmt

Done!