search

tbates / umx

Making Structural Equation Modeling (SEM) in R quick & powerful
https://tbates.github.io/
45 stars 17 forks source link

Allow xmu_make_bin_cont_pair_data to run w vars containing NAs #239

Closed lf-araujo closed 10 months ago

lf-araujo commented 10 months ago

umx_make_bin did not work if variable had NAs, it was a small issue with syntax. Passes local tests.

lf-araujo commented 10 months ago

I see the issue, it's a four lines change at the last loop. My editor changed tabs to spaces, this is the reason all lines are changed.

I can re-do it if you want.

Sorry for this.

-- T32 | Virginia Institute for Psychiatric and Behavioral Genetics | Richmond | US Department of Psychiatry | The University of Melbourne | AU p: +1 804 502-4074 | http://go.unimelb.edu.au/y5yr

From: Tim Bates @.> Sent: Saturday, January 6, 2024 12:57:05 PM To: tbates/umx @.> Cc: lf_araujo @.>; Author @.> Subject: Re: [tbates/umx] Allow xmu_make_bin_cont_pair_data to run w vars containing NAs (PR #239)

@tbates commented on this pull request.

hi, the whole of xmu_make_bin_cont_pair_data is coming up as changed. can you point me to the specific changes here?

— Reply to this email directly, view it on GitHubhttps://github.com/tbates/umx/pull/239#pullrequestreview-1807527541, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACNLSLTY6SR64XTYN6PBK4TYNGF7DAVCNFSM6AAAAABBPUQ4QCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQMBXGUZDONJUGE. You are receiving this because you authored the thread.Message ID: @.***>

tbates commented 10 months ago

hi, yes please: tabs and stick with = not <- (makes code reading and maintenance easier long term)