search

tbondois / odoo-ripcord

Ripoo is a PHP7 XML-RPC client handler for Odoo
MIT License
13 stars 15 forks source link

php8 and XML RPC #6

Open alan-smith-be opened 2 years ago

alan-smith-be commented 2 years ago

Hi,

due to : PHP 8.0 XMLRPC extension is moved to PECL

A simplier solution could be a compatible package instead of pecl install of extension

The package dependancy could be changed in composer.json from remove ext-xmlrpc "require": { "php": ">=7.0", "ext-xmlrpc": "*", "darkaonline/ripcord": "^0.1.6" },

to this composer package https://packagist.org/packages/phpxmlrpc/polyfill-xmlrpc 

"require": {
    "php": ">=7.0",
    "phpxmlrpc/polyfill-xmlrpc": "*",
    "darkaonline/ripcord": "^0.1.6"
},

any chances to confirm all functionnality and implement it in a new version ?

kr, Matthieu

tbondois commented 2 years ago

Hi Matthieu,

I don't maintain the project anymore, and i'm not working with PHP 8.0 yet. Your solution seems good but i prefer to not upgrade a library without testing it. So I'm suggesting you to fork it to do your own PHP 8 compat. If you do so, put your link here, can be useful for others users.

Thanks you for your interest !

its-leofisher commented 2 years ago

Hi,

due to : PHP 8.0 XMLRPC extension is moved to PECL

A simplier solution could be a compatible package instead of pecl install of extension

The package dependancy could be changed in composer.json from remove ext-xmlrpc "require": { "php": ">=7.0", "ext-xmlrpc": "*", "darkaonline/ripcord": "^0.1.6" },

to this composer package https://packagist.org/packages/phpxmlrpc/polyfill-xmlrpc

"require": {
    "php": ">=7.0",
    "phpxmlrpc/polyfill-xmlrpc": "*",
    "darkaonline/ripcord": "^0.1.6"
},

any chances to confirm all functionnality and implement it in a new version ?

kr, Matthieu

Needed this to work with our wordpress implementation so forked here with your suggestion but using RC > https://github.com/Sage-Goddess/odoo-ripcord-8