tbranyen / github-viewer

GitHub Viewer.
MIT License
366 stars 59 forks source link

Fixed checking of relative URLs #15

Closed sebdeckers closed 12 years ago

sebdeckers commented 12 years ago

Fixes the click-intercepting to check the correct part of the URL.

tbranyen commented 12 years ago

Thanks for this. I'm planning on changing the logic of this section soon to just detect for hashes. That should make it significantly easier.

sebdeckers commented 12 years ago

Oh my app URLs don't use hashes so the current logic is sufficient. I use an Nginx try_files redirect to index.html to preserve clean URLs (downside: need to handle 404's client-side which is not very nice HTTP-wise).

tbranyen commented 12 years ago

Doesn't matter. I'm only using it for route indication. Backbone will automatically convert from hash to pushState.

sebdeckers commented 12 years ago

Okay will see how it evolves :) Thanks for this awesome library, and the Backbone module pattern is great too!