tbranyen / github-viewer

GitHub Viewer.
MIT License
366 stars 59 forks source link

Linking to index to does not trigger index function #16

Closed DavidKruesemann closed 11 years ago

DavidKruesemann commented 12 years ago

When linking to index/default url, the index route doesn't trigger the index function.

Example:

 <a class="brand" href="/"> GitHub Organization Viewer</a>

Same problem when adding another route to call index function.

Example:

routes: {
      "": "index",
      "gohome": "index",
},

Any ideas so far?

tbranyen commented 12 years ago

set the href to "#"

DavidKruesemann commented 12 years ago

Tim, thanks - but this will only attach "#" to the current route, and not call the index function.

Example:

When I'm on "/org/bocoup" and then click the link to href="#", this will call "/org/bocoup#" (of course breaking the fetch from github, as there is no "bocoup#" organization).

Due to some initial research, this may somehow relate to some backbone pushState issues.

tbranyen commented 12 years ago

@DavidKruesemann ah, yeah there was a bug with the link hijack code. I'm going to port this over to the new code soon.

tbranyen commented 11 years ago

This is fixed in master.