search

tbranyen / github-viewer

GitHub Viewer.
MIT License
366 stars 59 forks source link

Div as tagName inside an item view #3

Closed ryancp closed 12 years ago

ryancp commented 12 years ago

Inside User.Views.List, you iterate through the collection and insert the entire list into a "ul".

And inside User.Views.Item, you set the tagName to "li".

Instead of a "ul", I would like to have my items be inside of a "div", and then my individual items also be inside of a "div".

But I tried this and it was re-rendering all the items inside of the div, for each item. IOW, for the first user, it would render every user, and the second user, it would render every user, etc.

How can I achieve a parent DIV with a list child DIV items? Or must the tags be different to render correctly?

Thanks for your help.

tbranyen commented 12 years ago

Could you provide some code as to what you were trying. Afaik, there are no problems with the rendering of divs inside divs.

ryancp commented 12 years ago

Sure, here's some code that results in the behavior: https://github.com/ryancp/layoutmanager-example/commit/db2942d07e721c67a2600e015adb38281538f877

tbranyen commented 12 years ago

Hey man, please re-open with valid code if this is still an issue. I don't think it should be with the latest LayoutManager.