tbroyer / gwt-maven-plugin

Starting fresh on building GWT projects with Maven
https://tbroyer.github.io/gwt-maven-plugin/
Apache License 2.0
166 stars 39 forks source link

Maven execution not supported? #167

Open leforthomas opened 3 months ago

leforthomas commented 3 months ago

I am transitioning from the "old" Mojo maven plugin to this one. I have a web app with multiple modules, which basically correspond to different use cases (customer, admin, operator). I need the whole webapp to be packaged as one war file.

I can compile one module at a time, no problem. For several modules I thought about using the maven executions, so I added several executions with the relevant configurations in each but this doesn't appear to work. The moduleName within the execution block is not caught and a compile will give the following error

The parameters 'moduleName' for goal net.ltgt.gwt.maven:gwt-maven-plugin:1.1.0:compile are missing or invalid

Is this scenario supported or should I try a different way to generate my modules?

tbroyer commented 3 months ago

I see no reason why it wouldn't be supported, are you sure you configured it for all executions? (and particularly for the default-compile one that's added by the gwt-app lifecycle, assuming you're using it?)

Can you share more complete build logs? Or maybe create an MCVE?

leforthomas commented 3 months ago

Thanks for moving the issue to the right repo ;-)

OK, got it, I was missing the skipModule in the plugin configuration, so it was first trying to generate a module and this is where it was failing, not during the executions.

The pom looks like this now

            <plugin>
                <groupId>net.ltgt.gwt.maven</groupId>
                <artifactId>gwt-maven-plugin</artifactId>
                <version>1.1.0</version>
                <extensions>true</extensions>
                <configuration>
                    <sourceLevel>11</sourceLevel>
                    <failOnError>true</failOnError>
                    <skipModule>true</skipModule>
                </configuration>
                <executions>
                    <execution>
                        <id>default-compile</id>
                        <configuration>
                            <moduleName>package.to.first.module</moduleName>
                        </configuration>
                    </execution>
                    <execution>
                        <id>secondModule</id>
                        <configuration>
                            <moduleName>package.to.second.module</moduleName>
                        </configuration>
                    </execution>
                </executions>
            </plugin>

If I'm honest I am not entirely sure how the default-compile works (despite reading the doc you sent), most likely due to my poor command of Maven in general...